Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update text input logic to v2 TextFieldState, part 3 [WPB-8779] #3054

Merged
merged 5 commits into from
May 31, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented May 29, 2024

TaskWPB-8779 Introduce BasicTextField2


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Android Compose has new v2 version of text field inputs, and with that, they are going away from the previous approach with TextFieldValue and onValueChanged and replacing it with TextFieldState.
We already updated text fields to v2 but still are using "hybrid" solution which synchronises between TextFieldValue/onValueChanged and TextFieldState.

In this PR, following screens, their ViewModels logic and tests are updated to use TextFieldState:

  • EnterLockCodeScreen

  • SetLockCodeScreen

  • ForgotLockCodeScreen

  • RegisterDeviceScreen

  • RemoveDeviceScreen

  • DeviceDetailsScreen

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Use text fields from any of listed screens.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk changed the title refactor: update text input logic to v2 TextFieldState, part 3 [WPB-8779] refactor: update text input logic to v2 TextFieldState, part 3 [WPB-8779] May 29, 2024
@AndroidBob
Copy link
Collaborator

Build 5079 failed.

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

@AndroidBob
Copy link
Collaborator

Build 5080 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team, yamilmedina, borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team May 29, 2024 15:31
@saleniuk saleniuk added this pull request to the merge queue May 31, 2024
Merged via the queue into develop with commit dea8a2f May 31, 2024
11 checks passed
@saleniuk saleniuk deleted the refactor/update-to-v2-textfieldstate-pt3 branch May 31, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants